assertj / assertj/assertj-generator
Running assertj generator on JDK 11
- Lenguaje dominante
- Java
- Estrellas
- 72
- Forks
- 47
- Merge medio
- 1 d 16 h
- PR fusionados (30 d)
- 2
Descripción
I am trying to build a library with OpenJDK 11 with the maven-assertj-generator plugin enabled. However, the plugin succeeds, but generates non-compiling code.
Has anyone had any succes on running the assertj-generator with OpenJDK 11?
Generated code:
```
/**
* Verifies that the actual Melding's referenties contains the given interface Referentie elements.
* @param referenties the given elements that should be contained in actual Melding's referenties.
* @return this assertion object.
* @throws AssertionError if the actual Melding's referenties does not contain all given interface Referentie elements.
*/
public MeldingAssert hasReferenties(interface Referentie... referenties) {
// check that actual Melding we want to make assertions on is not null.
isNotNull();
// check that given interface Referentie varargs is not null.
if (referenties == null) failWithMessage("Expecting referenties parameter not to be null.");
// check with standard error message, to set another message call: info.overridingErrorMessage("my error message");
Iterables.instance().assertContains(info, actual.getReferenties(), referenties);
// return the current assertion for method chaining
return this;
}
```
Wrong line:
`public MeldingAssert hasReferenties(interface Referentie... referenties) {`
Expected line:
`public MeldingAssert hasReferenties(Referentie... referenties) {`
To solve the issue, I tried building the assertj-assertions-generator on OpenJDK 11, but I also ran into all kinds of trouble.
* Tried to build a latest version of com.google.testing.compile:compile-testing
* Tried to upgrade Guava
* Needed to upgrade to JDK 8 source code
* Ran into troubles running JUnit Theories
Guía de contribución
Línea de trabajo
Comienza reproduciendo la ejecución de maven-assertj-generator en OpenJDK 11, utilizando el método generado MeldingAssert.hasReferenties como punto de entrada que falla. Revisa las restricciones de compilación de generator, compile-testing y Guava mencionadas en el informe y, después, ejecuta las JUnit Theories relevantes; se considera terminado cuando el método generado compila sin el token de interfaz no válido.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- build-system, tooling
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100