assertj / assertj/assertj-generator

The generator is a little too greedy with Iterable of Path and make tests fails

Aperta
#115 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
72
Fork
47
Merge medio
1g 16h
PR unite (30g)
2

Descrizione

With 2.1.0 version, the generator is too greedy when encountering a class implementing an `java.lang.Iterable`. It should ignore it unless the type extends `java.util.Collection` (where that make sense) or explicitly a `java.lang.Iterable` (where it is harder to tell it makes sense).

Sample classes: [assertj-foo.zip](https://github.com/joel-costigliola/assertj-assertions-generator/files/1377297/assertj-foo.zip)

The test (`FooTest`) will fail because the usage of hasPath is NOT the same than using an iterable: we want to test an equals rather than a collection predicate. Here the exception: _java.lang.AssertionError: Expecting: to contain: <[foobar\a]>but could not find: <[foobar\a]>_

A working alternative is to convert the Path into a List extracting the Iterable content, but that is wrong by all means:
- first, the default semantic is not good (the default = search for subsequence in any order)
- second, as an user, I want to test the path using `equals` (and that is what the generator produce if I have a class not implementing `java.lang.Iterable`):

```
final List paths = new ArrayList<>();
test.forEach(paths::add); // says ["foobar", "A"]
assertThat(foo).hasPath(paths);
```

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by unpacking the linked assertj-foo.zip sample and running FooTest to reproduce the failing hasPath assertion. Trace how the generator handles types implementing java.lang.Iterable, including the distinction from java.util.Collection. Done means Path-like Iterable types use equality semantics while collection types retain collection predicates, with the test passing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
tooling
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.