assertj / assertj/assertj-generator

The generator is a little too greedy with Iterable of Path and make tests fails

Open
#115 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
72
Forks
47
Avg merge
1d 16h
Merged PRs (30d)
2

Description

With 2.1.0 version, the generator is too greedy when encountering a class implementing an `java.lang.Iterable`. It should ignore it unless the type extends `java.util.Collection` (where that make sense) or explicitly a `java.lang.Iterable` (where it is harder to tell it makes sense).

Sample classes: [assertj-foo.zip](https://github.com/joel-costigliola/assertj-assertions-generator/files/1377297/assertj-foo.zip)

The test (`FooTest`) will fail because the usage of hasPath is NOT the same than using an iterable: we want to test an equals rather than a collection predicate. Here the exception: _java.lang.AssertionError: Expecting: to contain: <[foobar\a]>but could not find: <[foobar\a]>_

A working alternative is to convert the Path into a List extracting the Iterable content, but that is wrong by all means:
- first, the default semantic is not good (the default = search for subsequence in any order)
- second, as an user, I want to test the path using `equals` (and that is what the generator produce if I have a class not implementing `java.lang.Iterable`):

```
final List paths = new ArrayList<>();
test.forEach(paths::add); // says ["foobar", "A"]
assertThat(foo).hasPath(paths);
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.