arrayfire / arrayfire/arrayfire-python

OpenCL interoperability does not work on 64-bit OS

Aberta
#265 2 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
Python
Estrelas
422
Forks
63
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Currently the OpenCL interoperability does not work on 64-bit Windows machine. The reason for this is the use of `c_int_t` which defaults to long on Windows (which on the other hand is 32-bit). This can be problematic with things like device IDs as they can easily go over 2^32/2-1. For example https://github.com/arrayfire/arrayfire-python/blob/master/arrayfire/opencl.py#L88 uses `c_int_t`, as well as a few other functions in the same file. This can be fixed by replacing the `c_int_t` with, for example, `c_void_ptr_t` as it is used with the context. Is there by the way some specific reason why context is treated differently?

There is also another issue. When the context is created by PyOpenCL, the input device, context and queue values are input as python ints in order to use the same context and queue, but on Windows you get `: int too long to convert` errors then. These can be avoided by casting them to, for example, `c_int64`-types. For example in https://github.com/arrayfire/arrayfire-python/blob/master/arrayfire/opencl.py#L156, replace `safe_call(backend.get().afcl_add_device_context(dev, ctx, que))` with `safe_call(backend.get().afcl_add_device_context(ct.c_int64(dev), ct.c_int64(ctx), ct.c_int64(que)))` (using `c_void_p` seems to work too).

I haven't tested these changes extensively, but they do seem to get things working on 64-bit Windows. I can provide a PR if needed.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.