arduino / arduino/ArduinoCore-API

HardwareSerial::write(long/int) is incorrect/dangerous!

Open
#55 3 comments 0 reactions 1 assignee Claimed by @cmaglie View on GitHub
Dominant language
C++
Stars
306
Forks
150
PR merge metrics
No merged PRs in 30d

Description

any value above 255 will just be cut off -

```
inline size_t write(unsigned long n) { return write((uint8_t)n); }
inline size_t write(long n) { return write((uint8_t)n); }
inline size_t write(unsigned int n) { return write((uint8_t)n); }
inline size_t write(int n) { return write((uint8_t)n); }
```

please remove or fix the incorrect implementations!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.