appsmithorg / appsmithorg/appsmith

[Enhancement] Improve StyledComponents theme Autocomplete for React Client Code

Abierto
#6,843 21 comentarios 0 reacciones 1 asignado Asignado a @mahimathacker Ver en GitHub
Frontend Good First Issue hacktoberfest Task
Lenguaje dominante
TypeScript
Estrellas
40.9k
Forks
4.8k
Merge medio
1 d 22 h
PR fusionados (30 d)
45

Descripción

check the code here - https://github.com/appsmithorg/appsmith/blob/release/app/client/src/constants/DefaultTheme.tsx#L345

## Problem
Currently, for generic type value in theme for example `colors: any`, when we need to add something like
`color: ${props.theme.colors.dropdown.header.text};` using styled-components

We do not get an auto-complete prediction for such cases and also if wrote theme objects value reference incorrectly no error is generated.

## Expected

1. To see predictions when referring to theme objects value :

#### Example
```js
`props.theme.colors.dropdown.hea`
-- header
-- heading
```

2. See error when incorrectly used theme object
#### Example
```js
const theme = {
colors: {
primary: "#FFFFFF"
}
};

// demo component
const Wrapper = styled.div`
color: ${props => props.theme.colors.incorrectPrimary}; // Should show error - no incorrectPrimary is defined
`
```

## Solution
Ideally, we could generate the `Colors` type from the union of theme object's colors value & dark and light theme's color values.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.