appsmithorg / appsmithorg/appsmith

snapshot: deleteAllByApplicationId and createSnapshots not wrapped in transaction - server crash leaves application with no snapshot

Open Beginner friendly
#42,115 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
40.9k
Forks
4.8k
Avg merge
1d 22h
Merged PRs (30d)
45

Description

## Bug Description

createApplicationSnapshot calls deleteAllByApplicationId to remove all existing snapshot chunks, then calls createSnapshots to write the new ones. There is no transaction wrapping these two operations. If the server crashes or the MongoDB connection drops after the delete completes but before createSnapshots finishes, the application has no valid snapshot at all.

## Affected file

pp/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationSnapshotServiceCEImpl.java, lines 44-50:

`java
.flatMapMany(artifactExchangeJson -> {
return applicationSnapshotRepository
.deleteAllByApplicationId(branchedApplicationId) // (1) old snapshot destroyed
.thenMany(createSnapshots(branchedApplicationId, applicationJson)); // (2) new snapshot written
})
// no .as(transactionalOperator::transactional)
`

A TransactionalOperator bean is configured in MongoConfig.java. The import path at ImportServiceCEImpl.java:552 already uses .as(transactionalOperator::transactional) for its multi-step writes - the snapshot path has no equivalent.

## Failure scenario

1. Developer creates a snapshot before a risky refactor.
2. deleteAllByApplicationId commits - all previous snapshot chunks are gone.
3. Server receives SIGTERM (deploy restart), OOM kill, or MongoDB connection drops mid-write.
4. createSnapshots stops partway through - partial or zero chunks written.
5. Snapshot feature reports success or fails with no clear error, but the application has lost its snapshot entirely.
6. Developer encounters a problem with their refactor and tries to restore - finds no snapshot.

## Fix

Inject TransactionalOperator into ApplicationSnapshotServiceCEImpl (it is already available in the application context) and wrap both operations:

`java
return applicationSnapshotRepository
.deleteAllByApplicationId(branchedApplicationId)
.thenMany(createSnapshots(branchedApplicationId, applicationJson))
.as(transactionalOperator::transactional);
`

## Environment

Appsmith elease branch (2026-08-13), Java/Spring WebFlux, MongoDB.

Contributor guide

Open the contributing guide

Research direction

Start in app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationSnapshotServiceCEImpl.java around lines 44-50, then compare ImportServiceCEImpl.java:552 and the TransactionalOperator configuration in MongoConfig.java. Confirm that deletion and snapshot creation are covered by one transaction, so an interrupted write does not leave the application without its previous valid snapshot.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, mongodb, spring
Domain
backend, databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.