Implementation flaw

Hi there,

I think there is an implementation error in the sample project - more specifically, a flaw in the design of CKSyncEngine.
In the SyncedDatabase file, line 350:

self.syncEngine.state.add(pendingRecordZoneChanges: pendingSaves)

This tells the syncEngine what to do when the time is right. Since this piece of information is *not* persisted in this call (I think its persisted in .stateUpdate(let event)), there is a chance that this information is lost if the app crashes between .add(pendingRecordZoneChanges: pendingSaves) and .stateUpdate(let event).

I know this is just a sample project, but I really think this is a flaw in the API design of CKSyncEngine since I do not see an easy way to guarantee correct behavior. A simple fix would be to make .add(pendingRecordZoneChanges: pendingSaves) (and similar methods) async and only complete after .stateUpdate(let event) was called.

What do you think?

Inizia in SyncedDatabase alla riga 350 e verifica come vengono gestiti pendingRecordZoneChanges e l’evento stateUpdate. Valuta la finestra di crash descritta nell’issue e la modifica proposta all’API asincrona; il lavoro è completato quando esiste una risoluzione confermata da un maintainer per il problema di perdita di dati o di progettazione dell’API.

Scritto dal modello di indicizzazione a partire dal testo della issue.