appbaseio / appbaseio/reactivesearch

ci: add Node.js version matrix, caching, and lint step to test workflow

Abierto Apto para principiantes
#2,322 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
4.9k
Forks
478
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Problem

The CI workflow at `.github/workflows/test.yml` has several gaps:

1. Only tests on Node.js 22.x (volta config says 16 — mismatch)
2. No dependency caching between runs (slow CI)
3. No lint step in CI (eslint only runs via pre-commit hook)
4. Uses `actions/checkout@v2` and `actions/setup-node@v2` (both outdated)

## Suggested Fix

```yaml
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: cd packages/web && yarn build
- run: cd packages/web && yarn lint
- run: cd packages/web && yarn test --verbose --maxWorkers=2
```

## Severity

Medium — CI reliability and speed

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with .github/workflows/test.yml and inspect the existing test job, then compare its Node.js version with the Volta configuration mentioned in the issue. Update the workflow to cover the requested Node.js versions, dependency caching, current action versions, and the web lint command; run the workflow or its equivalent checks to confirm build, lint, and tests pass for every matrix entry.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions, javascript, nodejs
Área
ci-cd, devops, testing-qa
Tipo de issue
Nueva funcionalidad
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Tranquilo
Claridad
Bien especificado
Aptitud para principiantes
84/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.