appbaseio / appbaseio/reactivesearch

ToggleButton should not unselect active item - There should always be an item active

Abierto
#1,736 1 comentario 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
JavaScript
Estrellas
4.9k
Forks
478
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Affected Projects**
VueJS

**Is your feature request related to a problem? Please describe.**
ToggleButton unselects value when clicked on active item

**Describe the solution you'd like**
ToggleButton should not unselect value when clicked on active item. It should only change the active item when clicked on that active item

**Describe alternatives you've considered**
Not considered. But could be a custom reactive component.

**Additional context**
Could be a prop to have different behavior in case you want to continue to offer this option in both ways

**Steps to reproduce**
1. Initial state:
![image](https://user-images.githubusercontent.com/8817968/124781296-932dfe80-df43-11eb-9779-1692dab69aa7.png)

2. Change active item:
![image](https://user-images.githubusercontent.com/8817968/124781324-99bc7600-df43-11eb-9c24-31482aa46f7c.png)

3. Click active item (same item as step 2) - Undesired behavior
![image](https://user-images.githubusercontent.com/8817968/124781368-a345de00-df43-11eb-9548-a5a17b75432b.png)

4. Click active item (same item as step 2) - Desired behavior / Stays the same
![image](https://user-images.githubusercontent.com/8817968/124781324-99bc7600-df43-11eb-9c24-31482aa46f7c.png)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.