appbaseio / appbaseio/reactivesearch

DataSearch feedback for syntax errors

Abierto
#1,212 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
JavaScript
Estrellas
4.9k
Forks
478
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Affected Projects**
React

**Is your feature request related to a problem? Please describe.**
In my DataSearch input field, I want feedback if my input/syntax is invalid (or not if valid) while typing (or after pausing) - but I don't get feedback...
While typing not valid syntax, my elasticsearch backend is evaluating my input and responding with 400 Errors, which don't bubble into onError or renderError.

There is a console output for "index.js:1375" which is from an async Promise rejection in query.js -> redux -> DataSearch

**Describe the solution you'd like**
I want to access the error for my dataField and transform the error from elasticsearch into comprehensive user feedback (while parsing and transforming root causes and errors).
Getting the error response back would suffice for my use case, as standardized feedback would be great but a lot of work.
The error response should be thrown into the onError and renderError props.

**Describe alternatives you've considered**
I've considered using the transformResponse method in ReactiveBase, but I don't get the responses for 400 errors.
Generally, I've been using React ErrorBoundaries which should catch react errors - then I would display the error beside (not instead) the DataSearch component.

**Additional context**
I'm not sure if this is an actual feature request or a bug report, as I'm not sure about the intended behavior. Not breaking, while the syntax is not (yet) valid might be a good thing - for my use case of validation and helping the user to write valid syntax - it's not.
reactivesearch 3.0.3 - Elasticsearch v7

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.