appandflow / appandflow/react-native-safe-area-context

Question regarding web SafeAreaProvider `View` usage

Ouverte
#637 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
2.8k
Forks
258
Merge moyen
3 j 1 h
PR mergées (30 j)
2

Description

In this file, we have a `View`:

https://github.com/AppAndFlow/react-native-safe-area-context/blob/main/src/NativeSafeAreaProvider.web.tsx#L63

However, this was causing headaches with a web project of mine, seeing as the safe area context is provided at the root of a screen via `ExpoRoot`:

https://github.com/expo/expo/blob/fcebecf0d92682f81b50c7f0f1620f8ef9e4ebcb/packages/expo-router/src/ExpoRoot.tsx#L66-L72

And ultimately caused headaches in debugging a web app of mine:

https://x.com/crutchcorn/status/1930061117008519445

I don't see a reason why we'd need this `View` on web. Could we simply replace it with a `Fragment` instead? I'd be happy to make a PR for this

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.