appandflow / appandflow/react-native-safe-area-context

Question regarding web SafeAreaProvider `View` usage

Aperta
#637 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
2.8k
Fork
258
Merge medio
3g 1h
PR unite (30g)
2

Descrizione

In this file, we have a `View`:

https://github.com/AppAndFlow/react-native-safe-area-context/blob/main/src/NativeSafeAreaProvider.web.tsx#L63

However, this was causing headaches with a web project of mine, seeing as the safe area context is provided at the root of a screen via `ExpoRoot`:

https://github.com/expo/expo/blob/fcebecf0d92682f81b50c7f0f1620f8ef9e4ebcb/packages/expo-router/src/ExpoRoot.tsx#L66-L72

And ultimately caused headaches in debugging a web app of mine:

https://x.com/crutchcorn/status/1930061117008519445

I don't see a reason why we'd need this `View` on web. Could we simply replace it with a `Fragment` instead? I'd be happy to make a PR for this

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.