apollographql / apollographql/fullstack-tutorial
Confusing naming of function passed to Array.map
- 主要语言
- TypeScript
- 星标
- 1.2k
- 派生
- 808
- PR 合并指标
- 30 天内没有已合并 PR
描述
Hello,
not a real issue but just a naming of a method that confused me for a bit.
In [datasource/launch](https://github.com/apollographql/fullstack-tutorial/blob/master/final/server/src/datasources/launch.js#L10) there is method called `launchReducer` passed to `Array.map`. This method is responsible to take each launch returned by the Rest API and **mapping** it to another object.
So I guess this function should be called `lauchMapper`, because that's what it does. It doesn't reduce multiple element into a single one, isn't it?
Just highlighting this because it is a bit confusing
贡献指南
这个仓库没有索引到贡献指南
调研方向
打开 final/server/src/datasources/launch.js 中 launchReducer 的定义,并检查它传递给 Array.map 的位置。检查对该函数的任何其他引用,然后一致地更新命名,使函数名称能够反映其映射作用。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript
- 领域
- backend
- Issue 类型
- 重构
- 难度
- 1/5
- 预计耗时
- 1 小时以内
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 55/100