apollographql / apollographql/fullstack-tutorial

Bug in cancelTrip method from User datasource

Ouverte
#116 0 commentaires 0 réactions 1 personne assignée Réclamée par @stemmlerjs Voir sur GitHub
bug
Langage dominant
TypeScript
Étoiles
1.2k
Forks
808
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

https://github.com/apollographql/fullstack-tutorial/blob/66431a74abbdfd432157ec36a2fb7cd9f0b80be4/start/server/src/datasources/user.js#L60

Due to this line `cancelTrip` throws an error.

```sh
{
"errors": [
{
"message": "Cannot read property 'flight_number' of undefined",
"locations": [
{
"line": 2,
"column": 3
}
],
"path": [
"cancelTrip"
],
"extensions": {
"code": "INTERNAL_SERVER_ERROR",
"exception": {
"stacktrace": [
"TypeError: Cannot read property 'flight_number' of undefined",
// ....
```
Following change will fix the error.

```
async cancelTrip({ launchId }) {
const userId = this.context.user.id;
const numberOfDeletedTrips = await this.store.trips.destroy({ where: { userId, launchId } });
return numberOfDeletedTrips !== 0;
}
```
As per the [doc of `destroy`](https://sequelize.org/master/class/lib/model.js~Model.html#static-method-destroy) it returns number of deleted resources wrapped in Promise. So it should be resolved to get the count to decide if resources are deleted or not.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.