api-platform / api-platform/create-client

Dynamic entrypoint

Aperta
#248 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
376
Fork
132
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

**Description**
There should be an option to have a dynamic entrypoint when generating client code.

Currently the API endpoint passed to the generator is also used as entrypoint. This is not optimal:

1. A development setup may be accessed differently via CLI and via web (e.g. using internal service host names and public URLs in a Docker Compose setup)
2. Different environments need different host names, hardcoding one will break requests.

**Example**
Running the generator with `http://apache/api/` will generate all code and lead to exactly this being set in `config/entrypoint.js`. Now accessing `http://app.local/` will fail since `apache` is a host name internally resolved in a Docker Compose setup while the setup is accessed via `app.local` from the host machine.

Currently we work around this by adjusting `entrypoint.js` like this after generating the code:

```js
export const ENTRYPOINT = `${location.protocol}//${location.host}/api/`;
```

Maybe this or similar could be integrated for dynamic entrypoints.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.