api-platform / api-platform/create-client

Typescript: DateTime properties are mapped to Date objects but they should be string

未關閉
#131 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement TypeScript
主要語言
TypeScript
星號
376
分支
132
PR 合併指標
30 天內沒有已合併 PR

描述

As the title says, the typescript interface generator maps the date/datetime/time types to Typescript's Date object (https://github.com/api-platform/client-generator/blob/master/src/generators/TypescriptInterfaceGenerator.js#L47).

However, API Platform by default serializes DateTime objects as ISO 8601 strings, so we should change the type to `string` I think, otherwise we will run into all sorts of typescript errors when trying to use the date string (which the TS compiler would see as a Date object).

I could do a PR with the change from Date to string, however I have another question: Can the user change how PHP DateTimeInterface is serialized by Api Platform (i.e. from string to timestamp)? If so, how could we tell this to the client generator?

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。