apex / apex/up

Gradle clean doesn't use the Gradle wrapper when present

Đang mở
#782 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Go
Star
8.8k
Fork
383
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

## Prerequisites

* [x] I am running the latest version. (`up upgrade`)
* [x] I searched to see if the issue already exists.
* [x] I inspected the verbose debug output with the `-v, --verbose` flag.
* [ ] Are you an Up Pro subscriber?

## Description

TLDR: in the `javaGradle` support in `runtimes.go`, both the build and clean hooks should check for the availability of the gradle wrapper.

See https://github.com/apex/up/blob/c5f75ffec627c805a356b0c5cb47a0f4f3591875/config/runtimes.go#L95

The default clean hook fails for my project. In particular, my project is a Java Gradle project with the Gradle wrapper installed. I also have a local Gradle installation which is a different version than the wrapper. Due to https://github.com/johnrengelman/shadow/issues/287 , the project fails when running with the locally installed version of Gradle, but works when the wrapper is used. By default, up is currently using the wrapper for build, but the locally installed Gradle for clean.

## Steps to Reproduce

With a project that uses Gradle and has the wrapper installed, run `up deploy -v` and see that the clean didn't use the Gradle wrapper.

## Love Up?

Please consider signing up for Up Pro (https://up.docs.apex.sh/#guides.subscribing_to_up_pro) or donating via https://opencollective.com/apex-up/donate.

## Slack

Join us on Slack https://chat.apex.sh/

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.