apex / apex/up

Refactor cert approval check to account for existing cert

Open
#752 0 comments 0 reactions 0 assignees View on GitHub
UX
Dominant language
Go
Stars
8.8k
Forks
383
PR merge metrics
No merged PRs in 30d

Description

Currently if Up is waiting on a cert approval, and you `C^`, the next run will not output `Check your email to approve the certificate, resulting in a `up stack apply` attempting to use an unapproved certificate for the domain.

`createCerts()` uses some local state from `RequestCertificate` to see if we're waiting or not, it should just check pending certs instead to allow for both scenarios

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.