apache / apache/servicecomb-java-chassis

[BUG] - Java-Chassis3.2.1之后版本servicecomb.rest.client下的connection.maxPoolSize、http2.maxPoolSize、maxWaitQueueSize等配置项失效,只能使用固定默认值

Open
#4,854 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
1.9k
Forks
814
Avg merge
8d 23h
Merged PRs (30d)
1

Description

### Steps to Reproduce

Java-Chassis3.2.1 版本引入修改,创建HttpClient时原本使用 `xxx.createHttpClient(httpClientOptions)`, 修改为使用 `xxx.with(httpClientOptions)`

![Image](https://github.com/user-attachments/assets/b7137f86-25bd-49d2-bd8c-d1747ed3b165)

而`xxx.with(httpClientOptions)`只设置了`HttpClientOptions`

![Image](https://github.com/user-attachments/assets/926b91a9-4c03-4376-af89-6e4a95539b9c)

原本`xxx.createHttpClient(httpClientOptions)` 预期为同时修改`HttpClientOptions` 与 `PoolOptions`

![Image](https://github.com/user-attachments/assets/b1cd8d9f-6a4d-472c-9a48-063b4e6ce6d9)

导致在后续buildHttpClient时,`this.poolOptions`一直都为null,所以都是使用的默认`PoolOptions`

![Image](https://github.com/user-attachments/assets/a1a8f956-9af7-470f-ae43-2e8a1d7f1ed3)

![Image](https://github.com/user-attachments/assets/2b3f7a03-f3d7-4dc5-93ac-6ead1b70684c)

### Expected Behavior

预期只需要修改把`poolOptions`设置进去即可

![Image](https://github.com/user-attachments/assets/82c6dffd-e2f1-4976-8dcd-0a8163406db8)

### Servicecomb Version

_No response_

### Additional Context

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.