apache / apache/pulsar-client-node

No Error handling for Deserialize method which ends up crashing Node JS

未关闭
#422 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
164
派生
98
PR 合并指标
30 天内没有已合并 PR

描述

Hello Team

Here I am trying to serialize and deserialize messageId for my business use case

but issue is for proper error handling if in case we pass invalid buffer data to MessageId.deserialize method then it throws C++ exception
`libc++abi: terminating due to uncaught exception of type std::invalid_argument: Failed to parse serialized message id`
which is not handled by pulsar-client and node JS crashes

I see similar issue was there while creating a client too but that got fixed with this issue and PR https://github.com/apache/pulsar-client-node/pull/307/files
where it was wrapped with try catch block
but deserialize method is still not fixed

贡献指南

这个仓库没有索引到贡献指南

调研方向

从 MessageId.deserialize 开始,将其错误处理与 PR #307 中引入的客户端处理进行比较。复现无效缓冲区的情况,并跟踪 deserialize 绑定;当无效输入不再使 Node.js 因未捕获的 C++ 异常而终止时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
cpp, javascript, node.js
领域
api
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。