apache / apache/pulsar-client-node
Consider making "type" optional for AuthenticationOauth2
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 164
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
The C++ client does not seem to use the property `type`. Yet [it has been marked as required](https://github.com/apache/pulsar-client-node/blob/f696d2fd958b702122ca7a21f84642ea855ec25d/index.d.ts#L180). Please verify whether it is actually required and make it optional if not.
Thanks a bunch for your work on the Node.js client!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at index.d.ts around line 180 and inspect the AuthenticationOauth2 definition. Compare the C++ client's OAuth2 usage to determine whether type is required; done means the TypeScript declaration accurately reflects that requirement, making type optional if it is not used or needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, nodejs, typescript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100