apache / apache/pulsar-client-cpp

Custom LoggerFactory for log4cxx

Open
#376 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
71
Forks
90
Avg merge
2h 33m
Merged PRs (30d)
3

Description

FileLoggerFactory simply outputs logs to a single file.
If users want to rotate log files, they need to implement custom LoggerFactory by themselves.
Log4cxxLogger was deleted in #283, but this is useful for users.

So I would like to recover Log4cxxLogger.
I would not create specialized methods for Log4cxxLogger as there used to be, but would like to make it one of the options in the same category as ConsoleLoggerFactory and FileLoggerFactory.
https://github.com/apache/pulsar-client-cpp/pull/283/files#diff-abb02af9369945477ebc3329b299544ba67e214ac3f36c55b1f9e27f68469abf
If we want to avoid embedding it as a build option, we can separate the client and logger packages.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the #283 diff and the current ConsoleLoggerFactory and FileLoggerFactory implementations to see how logger options are exposed. Check the build and package layout before choosing between an embedded build option and separate client/logger packages. Done means Log4cxxLogger is restored as a peer option and users can use it for custom log rotation without specialized methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.