apache / apache/pulsar-client-cpp
[C++] pulsar-client-cpp stability enhancements and code cleanup
- 主要語言
- C++
- 星號
- 71
- 分支
- 90
- 平均合併
- 2 小時 33 分鐘
- 30 天內合併 PR
- 3
描述
Howdy! My company is investing heavily into event driven workflows, and we're utilizing Pulsar to accomplish this end. We're primarily a C++ shop, and I'm a Principal Engineer and in charge of the integration of Pulsar into our system, and experienced in C++. I've made a few bug fixes to the C++ client already, and in doing so I've noticed that it could use a bit of love to bring greater consistency to the design and fix up some low-hanging fruit. We've integrated Pulsar into our own build system, and it required a lot of changes to pass our build (which uses many more warnings and runs tests with ASAN). We've found that enforcing a more strict set of warnings helps to keep a c++ codebase healthy and stable, and I'd like to upstream these changes for the benefit of everyone, and to make continued maintenance easier.
Would anyone be opposed to me undertaking some general cleanup of the C++ client?
My proposed TODO list:
- Enable many more warnings (`-Wall`, `-Wvla`, `-Wformat-security`, etc)
- Enforce warnings as errors to prevent changes being submitted with warnings
- Fix all the subsequent warnings that will be generated
- Fix compatibility with boost 1.41 (the documentation claims it should be compatible, but it's not, and that happens to be the version we're stuck on).
- Use consistent format for `#include`s of local files (some have a `/lib` prefix, others don't)
- Run the tests via ASAN or Valgrind, if available (not sure how easy this will be yet...)
- Update syntax to take advantage of more C++11 features (like `std::make_shared`, move semantics, etc)
I'll obviously split this stuff up into a series of smaller changes. I'm hopeful that by doing this I'll gain more experience working with Pulsar and could potentially contribute more significant improvements in the future, i.e. performance enhancements and helping to keep feature parity between the C++ and Java clients.
Thanks!
貢獻指南
研究方向
此提案涵蓋 C++ 用戶端建置、警告、Boost 1.41 相容性、include 格式化、測試以及 C++11 更新,但未列出任何特定檔案或測試。先檢視目前的建置組態與測試設定,然後將 TODO 清單拆分為一項範圍明確的變更,並明確列出受影響的檔案與驗證標準。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- cpp
- 領域
- backend, build-system, testing
- Issue 類型
- 重構
- 難度
- 5/5
- 預估耗時
- 一週以上
- 活躍度
- 停滯
- 描述清晰度
- 需要釐清
- 新手友好度
- 25/100