apache / apache/parquet-java

Make PageReader AutoCloseable

Open Beginner friendly
#3,767 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

PageReader implementations can own resources — ColumnChunkPageReader owns decompression / decryption buffers — but the interface has no standard teardown method. Today ColumnChunkPageReadStore.close() calls a package-private releaseBuffers() on the concrete class. Alternative PageReader implementations have no idiomatic way to declare that they own resources.

Have PageReader extend AutoCloseable with a default no-op close(). Rename ColumnChunkPageReader.releaseBuffers() to close().

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the PageReader interface, then inspect ColumnChunkPageReader and ColumnChunkPageReadStore, especially the existing releaseBuffers() call. Make the interface resource-safe with a default teardown and ensure the concrete reader and store use the renamed close() method; run the relevant reader and page-store tests to confirm resource cleanup still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.