apache / apache/parquet-java

Setting parquet.thrift.string.size.limit = -1 incorrectly throws

Open Beginner friendly
#3,587 0 comments 0 reactions 0 assignees View on GitHub
Type: bug
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

### Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/parquet-java/pull/3359 added a `parquet.thrift.string.size.limit` configuration to allow specifying a custom max Thrift message size. If unspecified or explicitly set to -1, the default (100 MB) is used. The config validation code introduced a minor bug [here](https://github.com/apache/parquet-java/blob/8931c1c55f1fba399dd75139f75bcde0b84137c0/parquet-format-structures/src/main/java/org/apache/parquet/format/Util.java#L420): if the value is explicitly set to -1, `maxMessageSize` is correctly set to the default, but the `configuredMaxMessageSize <= 0` branch will still throw an exception.

### Component(s)

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in parquet-format-structures/src/main/java/org/apache/parquet/format/Util.java around the linked validation code near line 420. Reproduce the case where parquet.thrift.string.size.limit is explicitly set to -1, then verify that it uses the 100 MB default without throwing an exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.