apache / apache/parquet-java

Make the order of encodings in column metadata deterministic

Abierto
#3,215 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Type: enhancement
Lenguaje dominante
Java
Estrellas
3.1k
Forks
1.6k
Merge medio
3 d 12 h
PR fusionados (30 d)
33

Descripción

### Describe the enhancement requested

**Background**
The list of encodings used for a column is stored in the column metadata in the Parquet file footer.

The elements in this list are enumeration constants (`org.apache.parquet.format.Encoding`), which are collected in a `HashSet` when the records and fields are written. Later, when the footer is written, the set of enum constants are converted to a temporary list using the HashSet’s iteration order.

Since `Enum::hashCode` delegates to `Object::hashCode` (or, in later JDK versions, to `System::identityHashCode`), the order of the enum constants in this list can vary between runs in different processes, and thus files with identical encodings can represent this list differently (the elements may appear in different order).

**Rationale for changing this behaviour**
Two processes running the same version of parquet-java and having identical writer configurations can still produce files that are different at the binary level for the exact same written data.

For redundancy reasons, it is not uncommon to write data to Parquet files on two different machines. To verify that the same data has been written on both machines, it is currently not sufficient to compare the files ate the binary level. Instead, the files must be decoded and their actual data must be compared to ensure they are equal.

If the files can be made identical at the binary level, this verification process would be simplified.

**Suggested change**
The list of encodings is created in `org.apache.parquet.format.converter.ParquetMetadataConverter::toFormatEncodings`. A simple solution is to sort this list before it is returned, i.e. always return the `Encoding` enum constants in ascending ordinal order.

### Component(s)

Core

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Comience en org.apache.parquet.format.converter.ParquetMetadataConverter::toFormatEncodings e inspeccione cómo el HashSet de valores de Encoding se convierte en la lista devuelta. El trabajo estará terminado cuando la escritura de datos equivalentes produzca metadatos de Encoding en un orden ordinal ascendente determinista, eliminando el orden dependiente del proceso.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java
Área
data
Tipo de issue
Nueva funcionalidad
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
58/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.