apache / apache/parquet-java

Expected distinct numbers is not parsed correctly

Open
#2,451 2 comments 0 reactions 0 assignees View on GitHub
Component: Java Component: Parquet Priority: Critical Type: bug
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

In the bloom filter feature, when I pass the expected distinct numbers as below, I got null values instead of 1000 and 200.
```java

import org.apache.hadoop.conf.Configuration;

Configuration conf = new Configuration();

conf.set("parquet.bloom.filter.column.names", "content,line"); conf.set("parquet.bloom.filter.expected.ndv","1000,200");
```
 
The issue is coming from getting the system property of expected distinct numbers through [Long.getLong(expectedNDVs[i])|https://github.com/apache/parquet-mr/blob/a737141a571e3cb6cee2c252dc4406e26e6c1177/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java#L251].

 

It's possible to fix it by parsing the string with Long.parseLong(expectedNDVs[i]).

 

**Reporter**: [Walid Gara](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=garawalid) / @garawalid
**Assignee**: [Walid Gara](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=garawalid) / @garawalid
#### PRs and other links:
- [GitHub Pull Request #753](https://github.com/apache/parquet-mr/pull/753)

**Note**: *This issue was originally created as [PARQUET-1787](https://issues.apache.org/jira/browse/PARQUET-1787). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Research direction

Open parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java around line 251 and trace how parquet.bloom.filter.expected.ndv is read from the configuration. Reproduce the example with values 1000 and 200, then verify that the expected distinct numbers are retained instead of becoming null.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.