apache / apache/parquet-java

Integer Overflow of BinaryStatistics#isSmallerThan()

Open
#2,386 4 comments 0 reactions 0 assignees View on GitHub
Component: Java Component: Parquet Priority: Major Type: enhancement
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

"(min.length() + max.length()) < size" didn't handle integer overflow 

**Reporter**: [Xinli Shang](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=shangx@uber.com) / @shangxinli
**Assignee**: [Xinli Shang](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=shangx@uber.com) / @shangxinli
#### PRs and other links:
- [GitHub Pull Request #704](https://github.com/apache/parquet-mr/pull/704)
- [GitHub Pull Request #721](https://github.com/apache/parquet-mr/pull/721)
- [GitHub Pull Request #722](https://github.com/apache/parquet-mr/pull/722)

**Note**: *This issue was originally created as [PARQUET-1690](https://issues.apache.org/jira/browse/PARQUET-1690). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading parquet-column/src/main/java/org/apache/parquet/column/statistics/BinaryStatistics.java at line 103, then review pull requests #704, #721, and #722 to understand the current status. Done means the integer-overflow case in isSmallerThan() is addressed without duplicating work already covered by those pull requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.