apache / apache/parquet-java

The random data generator used for tests repeats the same value over and over again

Open
#2,199 0 comments 0 reactions 0 assignees View on GitHub
Component: Java Component: Parquet Priority: Minor Type: bug
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

The RandomValues class returns references to its internal buffer as random values. This buffer gets a random value every time a new random value is requested, but since earlier values reference the same internal buffer, they get changed to the same value as well. So even if successive calls return different values each time, the actual list of these values will always consist of a single value repeated multiple times. For example:

|n-th call|returned value|accumulated list expected|accumulated list actual|
|
|-|-|-|-|-|
|1|6C|6C|6C|
|
|2|8F|6C 8F|8F 8F|
|
|3|52|6C 8F 52|52 52 52|
|
|4|B8|6C 8F 52 B8|B8 B8 B8 B8|
|

**Reporter**: [Zoltan Ivanfi](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zi) / @zivanfi
#### PRs and other links:
- [GitHub Pull Request #504](https://github.com/apache/parquet-mr/pull/504)

**Note**: *This issue was originally created as [PARQUET-1353](https://issues.apache.org/jira/browse/PARQUET-1353). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the RandomValues class and read how it returns its internal buffer. Review Pull Request #504 for the existing work, then verify that accumulated random values remain distinct across successive calls and that the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.