apache / apache/parquet-java

Configure the encoding used by ValueWriters

未关闭
#1,989 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Component: Parquet Priority: Major Type: enhancement
主要语言
Java
星标
3.1k
派生
1.6k
平均合并
3 天 12 小时
30 天内合并 PR
33

描述

This was supposed to be tackled by jira: https://issues.apache.org/jira/browse/PARQUET-601 but that ended up being just the work done to refactor the ValuesWriter factory code out of ParquetProperties. As that is now merged, it would be nice to revisit the original purpose - being able to configure which type of ValuesWriters to be used for writing out columns.

Background: Parquet is currently structured to choose the appropriate value writer based on the type of the column as well as the Parquet version. Value writers are responsible for writing out values with the appropriate encoding. As an example, for Boolean data types, we use BooleanPlainValuesWriter (v1.0) or RunLengthBitPackingHybridValuesWriter (v2.0). Code to do this is in the [DefaultV1ValuesWriterFactory](https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV1ValuesWriterFactory.java#L31) and the [DefaultV2ValuesWriterFactory](https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV2ValuesWriterFactory.java#L35).

Would be nice to support being able to override the encodings in some way.
That allows users to experiment with various encoding strategies manually as well as enables them to override the hardcoded defaults if they don't suit their use case.

Couple of options I can think of:

Specifying encoding by type (or column):
```Java
parquet.writer.encoding-override. = "encoding1[,encoding2]"
As an example:
"parquet.writer.encoding-override.int32" = "plain"
```
Chooses Plain encoding and hence the PlainValuesWriter.

When a primary + fallback need to be specified, we can do the following:
```Java
"parquet.writer.encoding-override.binary" = "rle_dictionary,delta_byte_array"
```

Chooses RLE_DICTIONARY encoding as the initial encoding and DELTA_BYTE_ARRAY encoding as the fallback and hence creates a FallbackWriter(PlainBinaryDictionaryValuesWriter, DeltaByteArrayWriter).
In such cases we can mandate that the first encoding listed must allow for Fallbacks by implementing [RequiresFallback](https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/RequiresFallback.java#L31).

Another option suggested by @isnotinvain, was to allow overriding of the ValuesWriterFactory using reflection:
```Java
parquet.writer.factory-override = "org.apache.parquet.hadoop.MyValuesWriterFactory"
```

This creates a factory, MyValuesWriterFactory which is then invoked for every ColumnDescriptor to get a ValueWriter. This provides the flexibility to the user to implement a ValuesWriterFactory that can read configuration for per type / column encoding overrides. Can also be used to plug-in a more sophisticated approach where we choose the appropriate encoding based on the data being seen. A concern raised by @rdblue regarding this approach was that ValuesWriters are supposed to be internal classes in Parquet. So we shouldn't be allowing users to configure the ValuesWriter factories via config.

cc @julienledem / @rdblue / @isnotinvain for you thoughts / other ideas. We could also explore other ideas based on any other potential use cases.

**Reporter**: [Piyush Narang](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pnarang) / @piyushnarang

**Note**: *This issue was originally created as [PARQUET-682](https://issues.apache.org/jira/browse/PARQUET-682). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

贡献指南

这个仓库没有索引到贡献指南

调研方向

先阅读 DefaultV1ValuesWriterFactory.java 和 DefaultV2ValuesWriterFactory.java,然后检查 ValuesWriterFactory 和 RequiresFallback。该 issue 提出了多个尚未解决的配置设计,因此首先确定接受哪种方案。完成的标准是:用户可以按指定方式覆盖 value-writer 的编码或工厂,并且相关行为有测试覆盖。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
data-engineering
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。