apache / apache/parquet-java

Enhance the way path checking is done in ParquetFileWriter.mergeFooters

Open
#1,631 0 comments 0 reactions 0 assignees View on GitHub
Component: Java Component: Parquet Priority: Minor Type: enhancement
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

To ensure a metadata summary is only written to the same path as the files from which the summary is created, there is a check against the the root path for each footer's file. Only the path is compared, which leaves a possibility that the same path on 2 different types of filesystems (hdfs vs. file for example) could cause some unexpected or erroneous output.

This outcome would be unlikely, but it is not explicitly prevented anywhere which exposes risk to future changes.

**Reporter**: [Chris Albright](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ChrisAlbright)

**Note**: *This issue was originally created as [PARQUET-125](https://issues.apache.org/jira/browse/PARQUET-125). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating ParquetFileWriter.mergeFooters and inspect how each footer's file path is compared with the root path. Confirm the comparison includes the filesystem type as well as the path, and verify that summaries cannot combine files from different filesystem implementations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.