apache / apache/parquet-java

Investigate automatic not null checks via annotations in place of checkNotNull calls

Open
#1,446 0 comments 0 reactions 0 assignees View on GitHub
Component: Java Component: Parquet Priority: Minor Type: enhancement
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

We've discussed that it would be neat if we could replace a lot of the checkNotNull() calls in parquet-mr with an annotation like
```Java
@NotNull
```

or even make not null the default and annotate things that can be null with
```Java
@Nullable
```

and have this enforced by the compiler / annotation preprocessor.

**Reporter**: [Alex Levenson](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=alexlevenson) / @isnotinvain

**Note**: *This issue was originally created as [PARQUET-29](https://issues.apache.org/jira/browse/PARQUET-29). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by surveying checkNotNull() calls across parquet-mr and the project's current Java build configuration. Compare enforcing @NotNull by default versus annotating @Nullable values, including whether a compiler or annotation preprocessor is supported. Done means documenting a decided approach and its scope, or establishing why the change is not feasible.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.