apache / apache/openwhisk-cli

Trigger deleted even though the feed failed during deletion

Aperta
#158 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
Go
Stelle
109
Fork
98
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

@tareqmamari commented on [Tue May 17 2016](https://github.com/apache/incubator-openwhisk/issues/444)

I have a trigger and a feed associated to it, after I successfully created the trigger, I wanted to delete the trigger, thus, the feed will be executed with lifecycleEvent = 'DELETE' in order to handle deletion of event producer webhook, whenever the feed deletion life cycle is failed, the trigger will be deleted anyway which will lead to lose control on the services controlled by the feed ( resources used by the webhook).

e.g. : imagine the Github feed is successfully created , if you want to delete it ( assumption: deletion lifecycle is implemented within github webhook feed) and the feed is failed during the deletion , the feed ( trigger ) will be deleted anyway, so I have to delete the webhook manually which is a lose of control through Openwhisk

`error: failed to delete trigger feed rtiFeed but did delete the trigger
`

Is that unwanted behaviour ?

---

@rabbah commented on [Tue May 17 2016](https://github.com/apache/incubator-openwhisk/issues/444#issuecomment-219698538)

The intention when you delete the feed is to stop the trigger from firing, that is why the trigger is deleted even if the life cycle manager fails.

Your point is valid about having to delete it manually, we should make it easier to retry deleting the feed when it fails.

---

@tareqmamari commented on [Tue May 17 2016](https://github.com/apache/incubator-openwhisk/issues/444#issuecomment-219699376)

should we add an additional flag to enforce deleting the trigger whenever the feed fails ?

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia tracciando l'eliminazione dei trigger e l'eliminazione del ciclo di vita dei feed nella codebase openwhisk-cli; l'issue non indica alcun file o test. Confronta il comportamento attuale in caso di errore con l'intento dichiarato che il trigger smetta di attivarsi, quindi definisci e testa un modo per ritentare l'eliminazione fallita del feed senza perdere il controllo della risorsa esterna.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
go
Ambito
cli
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
25/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.