apache / apache/maven-source-plugin

TestSourceJarMojo forks to generate-sources instead of generate-test-sources

Aperta
#304 3 commenti 0 reazioni 1 assegnatario Rivendicata da @elharo Vedi su GitHub
bug priority:major
Lingua principale
Java
Stelle
37
Fork
38
Merge medio
18h 47m
PR unite (30g)
5

Descrizione

`TestSourceJarMojo.java:28` has `@Execute(phase = "generate-sources")`:

```java
@Mojo(name = "test-jar", defaultPhase = "package")
@Execute(phase = "generate-sources")
public class TestSourceJarMojo extends TestSourceJarNoForkMojo {
```

This is a test-jar goal but forks only to `generate-sources`, not `generate-test-sources`. If test sources are generated by another plugin in the `generate-test-sources` phase, they will not be available when the mojo runs, leading to an empty or incomplete test sources JAR.

Compare with `TestSourceGeneratedJarMojo.java:28` which correctly uses `generate-test-sources`:

```java
@Mojo(name = "generated-test-jar", defaultPhase = "package")
@Execute(phase = "generate-test-sources")
public class TestSourceGeneratedJarMojo extends TestSourceJarNoForkMojo {
```

**Fix**: Change the phase to `generate-test-sources`.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.