apache / apache/iotdb

[Bug] findColumn throws NullPointerException instead of SQLException for an unknown column name

Abierto Apto para principiantes
#18,250 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Java
Estrellas
6.4k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
115

Descripción

### Search before asking

- [x] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar.

### Version

`master` (2.0.x). The affected code is also present in released 2.0.x versions.

### Describe the bug and provide the minimal reproduce step

`IoTDBRpcDataSet.findColumn(String)` returns `columnOrdinalMap.get(columnName)` directly. When the column name is not present, `Map.get` returns `null`, which auto-unboxes to `int` and throws a `NullPointerException`. The JDBC contract (`ResultSet.findColumn`) requires a `SQLException` when the column is not found, and the sibling `findColumnNameByIndex` already guards its input and throws — the guard was simply omitted for `findColumn`.

This surfaces at the JDBC boundary (`IoTDBJDBCResultSet.findColumn`) and through `SessionDataSet.DataIterator.findColumn`, both of which delegate to the method above. The same missing guard also exists in `IoTDBJDBCDataSet.findColumn`.

Minimal reproduce step:

1. Execute any query over JDBC and obtain the `ResultSet`.
2. Call `resultSet.findColumn("a_column_name_that_is_not_in_the_result")`.
3. A raw `NullPointerException` is thrown instead of a `SQLException`.

### What did you expect to see?

`findColumn` throws a `SQLException` (at the JDBC boundary) that names the missing column, per the `ResultSet.findColumn` contract.

### What did you see instead?

A `NullPointerException`, from unboxing the `null` returned by the column-ordinal map lookup.

### Anything else?

The fix mirrors the existing `findColumnNameByIndex` guard: throw a checked `StatementExecutionException` at the rpc layer (reusing the existing `UNKNOWN_COLUMN_NAME` message), converted to `SQLException` at the JDBC boundary. I'd like to work on this and will open a PR (which also fixes the identical, currently-unused-but-public `IoTDBJDBCDataSet.findColumn`).

### Are you willing to submit a PR?

- [x] I'm willing to submit a PR!

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en IoTDBRpcDataSet.findColumn y compáralo con la comprobación guard existente de findColumnNameByIndex; después, sigue el límite de JDBC a través de IoTDBJDBCResultSet.findColumn y SessionDataSet.DataIterator.findColumn. Comprueba también IoTDBJDBCDataSet.findColumn; se considera terminado cuando una columna desconocida produce una SQLException que incluye el nombre de la columna que falta, en lugar de una NullPointerException.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java
Área
database
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Tranquilo
Claridad
Bien especificado
Aptitud para principiantes
78/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.