[Bug] Time-Zone problems in MonthIntervalFillFilterTest
- Lenguaje dominante
- Java
- Estrellas
- 6.4k
- Forks
- 1.2k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 115
Descripción
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar.
### Version
1.3.2-SNAPSHOT
### Describe the bug and provide the minimal reproduce step
When building IoTDB including tests in my timezone "Europe/Berlin" the tests in MonthIntervalFillFilterTest are failing.
### What did you expect to see?
I would have expected the tests to pass.
### What did you see instead?
[ERROR] Failures:
[ERROR] MonthIntervalFillFilterTest.testMonthIntervalMSFillFilter:51
[ERROR] MonthIntervalFillFilterTest.testMonthIntervalNSFillFilter:133
[ERROR] MonthIntervalFillFilterTest.testMonthIntervalUSFillFilter:90
### Anything else?
I have already found the problem, but am not sure how to correctly fix the issue.
The problem is that now 16.05.2024 in Germany we are in Daylight-Saving, which changes the timezone offset from 1h to 2h.
The AbstractMonthIntervalFillFilter uses the current timezone offset at the time of creating the instance.
Therefore the interval used in the test is "one hour less than one month", which makes the tests fail.
If I change:
this.zoneOffset = zone.getRules().getOffset(Instant.now());
To:
this.zoneOffset = zone.getRules().getStandardOffset(Instant.now());
The test passes again, but I am not sure this is the correct fix for it.
Another alternative would be to calculate the zoneOffset in the test based on the current time and not of that of the reference date in February (which is before daylight-saving)
### Are you willing to submit a PR?
- [x] I'm willing to submit a PR!
Guía de contribución
Línea de trabajo
Comienza con MonthIntervalFillFilterTest y el manejo del desplazamiento de zona horaria de AbstractMonthIntervalFillFilter. Ejecuta los tres métodos de prueba que fallan en la zona horaria Europe/Berlin y compara el desplazamiento utilizado por el filtro con la fecha de referencia de la prueba. Se considera terminado cuando las pruebas pasan y se conserva el comportamiento correcto del horario de verano.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- databases, testing
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100