apache / apache/iotdb-client-rust

SessionPool acquire: growth/hand-out failures bypass acquire_timeout budget; live counter decremented outside the state lock loses Condvar wakeups; acquire_timeout = Duration::MAX panics

未關閉
#6 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
Rust
星號
1
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

Three related pool-accounting defects found by stress-testing `SessionPool` against fake listeners:

1. **`acquire()` spends none of its `acquire_timeout` budget when the growth branch fails.** When `open_session()` fails, `acquire()` returns the error immediately (measured 198us against a 5s budget; 4136 of 4800 acquires failed instantly under stress while sessions were circulating). The same happens when the `USE` replay in `hand_out` fails — it discards the remaining idle candidates instead of retrying the loop.
2. **`live` is decremented outside the `state` lock at several sites**, and the decremented value is exactly the predicate parked waiters re-evaluate, so Condvar notifications can be lost. The comment "Only mutated while holding `state`" no longer matches the code. Measured stalls track `acquire_timeout` exactly (300ms → 305ms, 1000ms → 1.005s).
3. **`acquire_timeout = Duration::MAX` panics** on `Instant::now() + acquire_timeout` overflow before the lock is taken. There is no "never time out" option, and `Duration::MAX` is the natural way to ask for one.

Fix: on growth/hand-out failure, re-take the lock, decrement `live` under it, notify, and continue the loop (bounded by the original deadline); use a saturating deadline (`checked_add`) so `Duration::MAX` means "wait without timeout".

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start by locating SessionPool::acquire and tracing the open_session growth path and hand_out USE replay path, then inspect every live mutation relative to the state lock and Condvar notification. Verify that failures retry until the original deadline, live decrements notify waiters under the lock, and Duration::MAX waits without overflow; reproduce the behavior with fake-listener stress tests.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
rust
領域
databases
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
活躍
描述清晰度
基本清楚
新手友好度
62/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。