apache / apache/iceberg-python
Honor identity sort orders for Arrow table writes
- Langage dominant
- Python
- Étoiles
- 1.1k
- Forks
- 581
- Merge moyen
- 1 j 17 h
- PR mergées (30 j)
- 78
Description
## Feature Request / Improvement
PyIceberg accepts table sort orders at write time but ignores them. Arrow table writes produce unsorted data files and hard-code `sort_order_id=None`, so manifests are inconsistent with the sort order the user declared.
Related umbrella issue: #271
### Use case / motivation
Without a truthful sort_order_id and physically ordered data files, readers can't use sort-order-aware pruning and the manifest disagrees with the table's sort metadata. Users who declare a sort order expect their writes to honor it.
### Proposed change
When every sort field uses an identity transform and null placement is consistent, sort materialized Arrow table writes. Unpartitioned tables are sorted before bin packing and each final partition is sorted independently. The table's sort-order ID is recorded on the data files.
Unsupported transforms, nested or missing fields, mixed null placement, and streaming RecordBatchReader writes keep the current behavior. Files are marked unsorted and sort_order_id stays null, with a warning explaining why.
### Implementation
PR #3830 sorts the writes, carries the sort-order ID through WriteTask, writes the truthful DataFile.sort_order_id, and includes unit and integration coverage.
### Tooling note
I developed this with assistance from DS v4 Pro and reviewed the changes myself.
### References
- #271
- #3830
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Examinez d’abord la PR #3830, ainsi que la couverture unitaire et d’intégration qu’elle ajoute pour les écritures de tables Arrow. Vérifiez comment sont gérés les sort-order IDs, WriteTask, DataFile, manifests et bin packing. Le travail est terminé lorsque les identity-sort writes prises en charge produisent des fichiers ordonnés avec des valeurs sort_order_id exactes, tandis que les cas non pris en charge conservent le comportement et l’avertissement actuels.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- databases
- Type d'issue
- Fonctionnalité
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 25/100