apache / apache/iceberg-python

TruncateTransform.satisfies_order_of raises AttributeError for different widths

未關閉 適合新手
#3,680 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
1.1k
分支
581
平均合併
1 天 13 小時
30 天內合併 PR
76

描述

### Apache Iceberg version

0.11.0 (latest release)

### Please describe the bug 🐞

### Description

Calling `TruncateTransform.satisfies_order_of` with two valid truncate transforms that have different widths raises an `AttributeError` instead of returning a boolean.

Same-width comparisons work because the method returns early when the transforms are equal.

### Reproduction

```python
from pyiceberg.transforms import TruncateTransform

TruncateTransform(5).satisfies_order_of(TruncateTransform(3))
```

On `main` at commit `48e710d20ceeeaa637d5aeae7746b787410859f8`, this raises:

```text
AttributeError: 'TruncateTransform' object has no attribute '_source_type'
```

The failure reproduces consistently. The same code is also present in the 0.11.1 release.

### Expected behavior

The method should compare the truncate widths and return a boolean:

```python
assert TruncateTransform(5).satisfies_order_of(TruncateTransform(3))
assert not TruncateTransform(3).satisfies_order_of(TruncateTransform(5))
```

This matches the current Apache Iceberg Java implementation:

https://github.com/apache/iceberg/blob/25654ab4b29c8b5b5c20fc427da01cb70d94ed14/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L130-L141

### Cause

`TruncateTransform.__init__` initializes `_width` but not `_source_type`. However, `satisfies_order_of` still accesses the `source_type` property backed by `_source_type`:

https://github.com/apache/iceberg-python/blob/48e710d20ceeeaa637d5aeae7746b787410859f8/pyiceberg/transforms.py#L783-L905

The existing unit test only compares a transform with itself, so it returns before reaching the failing branch:

https://github.com/apache/iceberg-python/blob/48e710d20ceeeaa637d5aeae7746b787410859f8/tests/test_transforms.py#L501-L512

A focused fix could compare `TruncateTransform` widths directly, consistent with the Java implementation, and add regression cases for different widths.

I would be happy to contribute the fix and regression tests.

### Willingness to contribute

- [x] I can contribute a fix for this bug independently
- [ ] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
- [ ] I cannot contribute a fix for this bug at this time

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

從 pyiceberg/transforms.py 中的 TruncateTransform.satisfies_order_of 開始,檢查相關的建構函式和 source_type 屬性。執行 tests/test_transforms.py 中 501-512 行附近的重點案例,然後為不同的寬度新增覆蓋。完成的標準是:比較會傳回預期的布林值,且不會存取未初始化的屬性。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
data-engineering
Issue 類型
缺陷
難度
2/5
預估耗時
1-3 小時
活躍度
冷清
描述清晰度
描述清楚
新手友好度
82/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。