apache / apache/datasketches-java
Add proper module name in Manifest
- Dominant language
- Java
- Stars
- 958
- Forks
- 226
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 8
Description
Hello,
Any plan to add proper jpms/JDK9 module configuration into the library?
Current manifest looks like :
```
Manifest-Version: 1.0
Build-Jdk-Spec: 25
Build-OS: Mac OS X aarch64 26.1
Build-Tool-Jdk-Spec: 25
GroupId-ArtifactId: org.apache.datasketches:datasketches-java
Implementation-Vendor: The Apache Software Foundation
git-branch: 9.0.X
git-commit-id: f3b334b380feee9f928500de9adb6bbf763fc104
git-commit-tag: 9.0.0-RC1
git-commit-time:
git-commit-user-email: xxx@yyy.com
```
An easy way forward would be through an additional `Automatic-Module-Name` entry, like:
```
Automatic-Module-Name: org.apache.datasketches
```
it can be done with something like:
```
org.apache.maven.plugins
maven-jar-plugin
org.apache.datasketches
```
*edit: I would benefit from this going from datasketches 7.X*
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the Maven build configuration that creates the library JAR and compare its generated manifest with the example in the issue. Add the requested Automatic-Module-Name entry through the jar manifest configuration, then verify that the built manifest contains org.apache.datasketches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100