apache / apache/datafusion

`date_bin` and `date_trunc` disagree on timezone-aware timestamps

未关闭
#25,167 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
Rust
星标
9.3k
派生
2.4k
平均合并
3 天 11 小时
30 天内合并 PR
362

描述

### Describe the bug

`date_trunc` and `date_bin` give different answers for the same timezone-aware value and the same unit. `date_trunc` works in the value's own timezone; `date_bin` works on the UTC instant and then relabels.

For whole-hour zones the difference is visible but each answer is at least a local midnight. For a zone whose offset is not a whole multiple of the stride it is worse — `date_bin` returns something that is not a boundary in either timezone:

```sql
SELECT arrow_cast(TIMESTAMP '2024-01-01 12:00:00','Timestamp(Second, Some("Asia/Kolkata"))') AS t,
date_trunc('day', ...) AS dtrunc,
date_bin(INTERVAL '1 day', ...) AS dbin;

+---------------------------+---------------------------+---------------------------+
| t | dtrunc | dbin |
+---------------------------+---------------------------+---------------------------+
| 2024-01-01T12:00:00+05:30 | 2024-01-01T00:00:00+05:30 | 2024-01-01T05:30:00+05:30 |
+---------------------------+---------------------------+---------------------------+
```

`05:30:00+05:30` is UTC midnight rendered in Kolkata. It is not a day boundary in Kolkata, and as a `GROUP BY` key it is surprising.

America/Denver shows the same disagreement in the more familiar form: `date_trunc` gives `2024-01-01T00:00:00-07:00`, `date_bin` gives `2023-12-31T17:00:00-07:00`.

### To Reproduce

The queries above, on DataFusion 55.0.0 (`da89c7c85b`).

### Expected behavior

Not obvious, which is why I am filing it rather than proposing a patch. Each function individually matches PostgreSQL — PG's `date_trunc(field, timestamptz)` truncates in the session zone and PG's `date_bin` is instant-based — so neither is wrong on its own. What is missing is that the pair is inconsistent, nothing in the codebase or documentation records that this is intentional, and there is no way for a user to discover it short of comparing outputs.

At minimum the difference should be a deliberate, documented decision. Options that seem worth weighing:

- Give `date_bin` an optional timezone argument, or make it timezone-aware for whole-calendar-unit strides.
- Leave the behaviour and document it prominently on both functions.

Related: #10602 asks for local-calendar binning and is still open for exactly this reason; the current answer is to compose `date_bin` with `to_local_time`. #13962 is a different symptom of timezone-sensitive grouping.

Found while adding timezone characterization tests in #25164.

贡献指南

打开贡献指南

调研方向

从 date_trunc 和 date_bin 入口点开始,运行报告中的 Asia/Kolkata 和 America/Denver 查询。阅读 #25164 中新增的时区特征测试,以及 #10602 和 #13962 的上下文。完成的标准是:该行为已成为一项明确且经过审查的决定,并且相关行为已记录文档,或已明确规定约定的 API 变更。

由索引模型根据 Issue 内容生成。

评估

技术栈
rust, sql
领域
databases
Issue 类型
缺陷
难度
5/5
预计耗时
一周以上
活跃度
活跃
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。