Improve error message in `sqllogictest` with `<slt:ignore>` marker
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
### Is your feature request related to a problem or challenge?
Follow up to https://github.com/apache/datafusion/pull/18857
With `` feature, if the actual and expected is not matched, we got error message like
```
2. query result mismatch:
[SQL] select * from generate_series(3);
[Diff] (-expected|+actual)
-
+ 0
1
- 3
+ 2
3
at /Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/slt_features.slt:84
```
The first diff is a false positive, and the second one is expected. It would be great to suppress the 1st diff.
Also, the error message rendering and the actual validation for `sqllogictest` seems to live in two different places, it would be better to combine them.
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
Contributor guide
Research direction
Reproduce the mismatch from datafusion/sqllogictest/test_files/slt_features.slt at line 84, then trace the separate sqllogictest validation and error-rendering locations mentioned in the issue. The completed change should suppress the false-positive diff caused by while still reporting the real mismatch, with coverage for this output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100