apache / apache/datafusion

Improvements to ` BooleanGroupValueBuilder` (grouping by boolean columns)

Aperta
#17,860 2 commenti 0 reazioni 1 assegnatario Rivendicata da @ggyuchive Vedi su GitHub
enhancement performance
Lingua principale
Rust
Stelle
9.3k
Fork
2.4k
Merge medio
3g 11h
PR unite (30g)
360

Descrizione

### Is your feature request related to a problem or challenge?

@ashdnazg added an optimized `BooleanGroupValueBuilder` in https://github.com/apache/datafusion/pull/17726, and @rluvaton had several ideas for a follow on optimizations:

https://github.com/apache/datafusion/pull/17726/files#r2387673598

> Because this is a slice and not buffer this limit optimizations in my optimization for creating optimized version for all uniuqe, for example for non nullable checking if 2 arrays are the same is simple NOT XOR

https://github.com/apache/datafusion/pull/17726/files#r2387686684

> I will try to change it to MutableBooleanBuffer or something in the future to allow for more optimizations

### Describe the solution you'd like

This ticket tracks improving the performance of the `BooleanGroupValueBuilder`, perhaps using @rluvaton 's suggestions

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.