apache / apache/datafusion

Improvements to ` BooleanGroupValueBuilder` (grouping by boolean columns)

Open
#17,860 2 comments 0 reactions 1 assignee Claimed by @ggyuchive View on GitHub
enhancement performance
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

@ashdnazg added an optimized `BooleanGroupValueBuilder` in https://github.com/apache/datafusion/pull/17726, and @rluvaton had several ideas for a follow on optimizations:

https://github.com/apache/datafusion/pull/17726/files#r2387673598

> Because this is a slice and not buffer this limit optimizations in my optimization for creating optimized version for all uniuqe, for example for non nullable checking if 2 arrays are the same is simple NOT XOR

https://github.com/apache/datafusion/pull/17726/files#r2387686684

> I will try to change it to MutableBooleanBuffer or something in the future to allow for more optimizations

### Describe the solution you'd like

This ticket tracks improving the performance of the `BooleanGroupValueBuilder`, perhaps using @rluvaton 's suggestions

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.