apache / apache/datafusion

Attach `Diagnostic` to "wrong number of arguments" error

Aperta
#14,432 15 commenti 0 reazioni 1 assegnatario Rivendicata da @Chen-Yuan-Lai Vedi su GitHub
enhancement good first issue
Lingua principale
Rust
Stelle
9.3k
Fork
2.4k
Merge medio
3g 11h
PR unite (30g)
362

Descrizione

### Is your feature request related to a problem or challenge?

For a query like:

```sql
SELECT sum(1, 2)
```

The only message that the end user of an application built atop of DataFusion sees is:

```
Error during planning: Execution error: User-defined coercion failed with Execution("SUM expects exactly one argument") No function matches the given name and argument types 'sum(Int64, Int64)'. You might need to add explicit type casts.
Candidate functions:
sum(UserDefined)
```

We want to provide a richer message that _references and highlights locations in the original SQL query_, and contextualises and helps the user understand the error. In the end, it would be possible to display errors in a fashion akin to what was enabled by #13664 for some errors:

![](https://github.com/user-attachments/assets/32efeb4f-aad9-41c9-a1e3-600a00d525c3)

See #14429 for more information.

### Describe the solution you'd like

Attach a well crafted `Diagnostic` to the `DataFusionError`, building on top of the foundations laid in #13664. See #14429 for more information.

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.