apache / apache/datafusion-sqlparser-rs
Cannot parse named windows with modifiers
- Lingua principale
- Rust
- Stelle
- 3.5k
- Fork
- 772
- Merge medio
- 4g 9h
- PR unite (30g)
- 17
Descrizione
sqlparser-rs only supports named windows that are an identifier. This is fine for queries like:
```sql
SELECT sum(salary) OVER w, avg(salary) OVER w
FROM empsalary
WINDOW w AS (PARTITION BY depname ORDER BY salary DESC);
```
However, it is insufficient for queries in at least BigQuery and MySQL where modifiers can be added to the named window in the OVER clause.
[MySQL named window example](https://dev.mysql.com/doc/refman/8.0/en/window-functions-named-windows.html)
```sql
SELECT
DISTINCT year, country,
FIRST_VALUE(year) OVER (w ORDER BY year ASC) AS first,
FIRST_VALUE(year) OVER (w ORDER BY year DESC) AS last
FROM sales
WINDOW w AS (PARTITION BY country)
```
[BigQuery named window example](https://cloud.google.com/bigquery/docs/reference/standard-sql/window-function-calls)
```sql
SELECT item, purchases, category, LAST_VALUE(item)
OVER (
item_window
ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING
) AS most_popular
FROM Produce
WINDOW item_window AS (
PARTITION BY category
ORDER BY purchases)
```
This would build upon prior to work:
- https://github.com/sqlparser-rs/sqlparser-rs/issues/867
- https://github.com/sqlparser-rs/sqlparser-rs/pull/881
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Direzione di ricerca
Inizia esaminando come sqlparser-rs analizza l'espressione named-window nella clausola OVER, quindi esamina l'issue #867 e la pull request #881 per il design precedente. Aggiungi la copertura di parsing per gli esempi MySQL e BigQuery e verifica che le named windows con modificatori vengano accettate senza introdurre regressioni per le named windows semplici.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- rust, sql
- Ambito
- compilers, databases
- Tipo di issue
- Funzionalità
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 40/100