apache / apache/datafusion-sqlparser-rs

Remove or document second field in `Value::Number`

Open
#363 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

Value::Number should be changed from a tuple variant to a struct variant so that the field names are self documenting.
Something like: `Number { value: String, long: bool }`

Possibly the long field could be just removed instead but not im not very familar with various SQL languages.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Value::Number definition and every constructor and pattern match that uses it. Check the supported SQL dialects to determine whether the long field is required; done means the variant is self-documenting or the field is removed, with all references compiling and the existing tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.