apache / apache/datafusion-sqlparser-rs

Bitwise `&` and `->` group differently in the PostgreSQL and MySQL/Generic dialects

Offen Anfängerfreundlich
#2,461 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
3.5k
Forks
772
Ø Merge
4 T. 9 Std.
Gemergte PRs (30 T.)
17

Beschreibung

`&` and `->` have the same precedence in PostgreSQL but not in the default precedence table, so the
same expression produces two different trees depending on dialect:

| SQL | `PostgreSqlDialect` | `MySqlDialect` / `GenericDialect` |
|---|---|---|
| `a -> b & c` | `((a -> b) & c)` | `(a -> (b & c))` |
| `a -> b \| c` | `((a -> b) \| c)` | `((a -> b) \| c)` |
| `a -> b ^ c` | `(a -> (b ^ c))` | `(a -> (b ^ c))` |
| `a -> b + c` | `(a -> (b + c))` | `(a -> (b + c))` |

`&` is the only row that disagrees.

### Cause

The default table in `src/dialect/mod.rs` has:

```rust
Precedence::Ampersand => 23,
Precedence::Caret => 22,
Precedence::Pipe => 21,
Precedence::Colon => 21,
Precedence::PgOther => 21,
```

`PostgreSqlDialect::prec_value` instead maps `Ampersand`, `Pipe`, `Colon` and `PgOther` all to
`PG_OTHER_PREC` (`src/dialect/postgresql.rs:176-184`), which matches `gram.y`, where `&` is just a
generic `Op` and shares one left-associative level with `->`:

```
%left Op OPERATOR RIGHT_ARROW '|'
```

So `Pipe` already agrees with `PgOther` in the default table (both 21), and `Caret` is legitimately
above it, but `Ampersand` at 23 is left as the sole outlier.

### Candidate fix

```diff
- Precedence::Ampersand => 23,
+ Precedence::Ampersand => 21,
```

The full suite passes unchanged with that applied, so no existing test pins the current grouping —
which is also why this went unnoticed. `Display` for `Expr::BinaryOp` emits no parentheses, so a
mis-grouped tree round-trips to the original SQL and `verified_expr` / `verified_stmt` cannot catch
it; a test would have to assert on the tree.

### Open question, possibly a separate issue

For MySQL the fix above is necessary but not sufficient. MySQL's `->` / `->>` take a quoted JSON path
on the right-hand side, so there is nothing for MySQL to resolve — `col->'$.a' + 1` can only mean
`(col->'$.a') + 1`. sqlparser parses that right operand as a full expression at `PgOther`, giving
`col -> ('$.a' + 1)`, so `->` under-binds in MySQL against `+`, `*`, `^` and friends, not just `&`.
Making that correct probably means a MySQL-specific precedence for the arrow operators rather than
another adjustment to the shared row, so I've kept it out of scope here — happy to split it out if
a maintainer would prefer it tracked separately.

Surfaced while working on #2436. Related: #2460.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Beginnen Sie in src/dialect/mod.rs mit der standardmäßigen Präzedanztabelle und vergleichen Sie sie anschließend mit PostgreSqlDialect::prec_value in src/dialect/postgresql.rs:176-184 sowie der im Issue zitierten PostgreSQL-Regel aus gram.y. Fügen Sie einen Regressionstest auf Baumebene für `a -> b & c` hinzu, da SQL-Round-Trip-Tests die Gruppierung nicht erkennen können, und führen Sie die vollständige Testsuite aus, um die Änderung zu überprüfen.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
mysql, postgresql, rust
Bereich
compilers, databases
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
78/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.