apache / apache/datafusion-sqlparser-rs

`DROP` statement should be grouped by

Open
#2,058 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

Hi,

I noticed that while there exist a more generic `Drop` variant, there also exist separate `DropFunction`, `DropDomain`, `DropSecret` etc.. and I believe that these variants could and should be folded into the more generic `Drop` variant.

Do let me know whether you also believe this to be the case.

I may take care of this in a future PR when I get the time.

Best,
Luca

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Rust AST definitions for the generic Drop variant and the separate DropFunction, DropDomain, and DropSecret variants. Review how these variants are parsed and represented, then consolidate them and verify that existing SQL parsing behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.